Page MenuHomePhabricator

meson: add inital support for windows compilation
ClosedPublic

Authored by bu5hm4n on Tue, Dec 4, 12:09 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Tue, Dec 4, 12:09 PM
bu5hm4n requested review of this revision.Tue, Dec 4, 12:09 PM
stefan_schmidt added inline comments.Thu, Dec 6, 6:28 AM
src/bin/elementary/meson.build
244

Ah, here is the hunk hiding I was missing from patch D7415. :-)

src/lib/emile/meson.build
31 ↗(On Diff #17765)

Unrelated change?

src/static_libs/draw/meson.build
24

Can you explain this a bit further? A simple re-factor?Looks like we are only removing one indirection but to be honest I am not sure. Same for the rg_etc change below.

bu5hm4n added inline comments.Thu, Dec 6, 8:41 AM
src/bin/elementary/meson.build
244

Something went wrong here when committing, will try to get this hunk into the other patch.

src/static_libs/draw/meson.build
24

On a linux system it is not a problem to link one and the same .a into two .so's which are then later linked into another .so. However, windows is special, linking .a into two .dll make the .a api available from the two .dlls, which makes linking the last .dll fail, caused by duplicated symbols. However, packing the source just into the .dlls instead of using it with a .a makes it *magically* work.

I try to avoid that as much as i can because i don't want to have issues for example in evas.so linking which are actaully caused by a static library. So i try to keep this way of working as rare as possible.

stefan_schmidt added inline comments.Fri, Dec 7, 2:35 AM
src/lib/evil/meson.build
63

This will most likely need a -lmsvcr100 now as well due to the _create_locale symbol (at least its needed for the autotools build)

stefan_schmidt accepted this revision.Fri, Dec 7, 4:04 AM
This revision is now accepted and ready to land.Fri, Dec 7, 4:04 AM
Closed by commit rEFL500a36ba3d3d: meson: add inital support for windows compilation (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Dec 7, 4:06 AM
This revision was automatically updated to reflect the committed changes.