Page MenuHomePhabricator

elm_map: Add new overlay content to the list of smart members of wigdget
ClosedPublic

Authored by michael.bouchaud on Dec 14 2018, 6:23 AM.

Details

Summary

Without this a new overlay content aren't displayed into the map widget.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8429
Build 7585: arc lint + arc unit
michael.bouchaud requested review of this revision.Dec 14 2018, 6:23 AM

In reviewing this, the code looks ok ... but is there a way to test this specific change ? Within elementary_test Map, I can already add Overlay items to the map and they do show up .... so I am just wondering how to test this specific change.

Yes indeed, you could test this with my weather gadget (devs/yoz/e_gadget_weather)
Launch e_gadget_weather_map.
In elm_test none of the overlay are customized with a call to content_set, so we don't see any issue.

Yes indeed, you could test this with my weather gadget (devs/yoz/e_gadget_weather)
Launch e_gadget_weather_map.
In elm_test none of the overlay are customized with a call to content_set, so we don't see any issue.

Actually, in reading the elm_map test code, there are calls to elm_map_overlay_content_set ... test_map.c: 1208

Ha yes I've forgotten this one. I think this work here because we have only an elm_map on the window and nothing else.

michael.bouchaud added a comment.EditedJan 11 2019, 6:58 AM

Without my patch


With my patch

Look how the segment_control is displayed in both case (Upper right gadget).
Without my patch the overlay is displayed onto the segment_control.
With my patch all is fine.

devilhorns accepted this revision.Jan 11 2019, 7:14 AM

ok yea, I was able to finally get this working and the patch does work as expected :)

This revision is now accepted and ready to land.Jan 11 2019, 7:14 AM
devilhorns closed this revision.Jan 11 2019, 7:14 AM