This is a great start for testing, thanks for taking the time to work on it. I like the diagrams, but those won't be accessible to anyone using git log or in the event that the project moves away from phabricator. It may be worth adding the diagram image files into the patch and keeping them in a subdir of the unit tests so people can easily reference them?
But, image file is hard to maintain..
What do you think of the diagram viewer?
source code :
Hints struct can be shared with efl_ui_hint_data.c file which have global Hint struct array. (see line 9 #include "efl_ui_hint_data.c")
Hint properties can be displayed in popup when the button is clicked. it is not implemented yet.
When someone want to modify container unit test, they just need to edit efl_ui_hint_data.c.
I like this idea, but I'm concerned that this adds too much burden to anyone trying to view it or add tests.
Let's compromise for now: start a wiki page here for something like "unit test flowcharts" and post the images there along with the tests they relate to. Then you can put a link to that page in the commit log here (maybe also in the file?) so people can reference it. I'll merge this patch once the updates are done.
Actually, I have one test case I'd like to see added: can you add a test where:
- the box has 3 contents with no size hints other than an aspect hint (BOTH, 1:3)
- the box is sized something like 300x900
- verify that the contents are all 100x300
- resize box to 150x450
- verify contents are all 50x150
I think this is likely to be a common use case.