Page MenuHomePhabricator

Efl.Ui.List_View: precise layout async
ClosedPublic

Authored by larryolj on Dec 18 2018, 11:00 AM.

Details

Summary

fixed precise layouter to work with create asynchronous
fixed example theme signal

Diff Detail

Repository
rEFL core/efl
Branch
listfix
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8468
Build 7610: arc lint + arc unit
larryolj created this revision.Dec 18 2018, 11:00 AM
larryolj requested review of this revision.Dec 18 2018, 11:00 AM

I agree that it would be much better to separate the layouting method,
but I'm not sure why this content_created need to be asynchronous.
I've faced a lot of issue when group calculation demand view update, but view deffered the update.
I think if it reached group_calculate, view need to be updated in the same render frame.

SanghyeonLee accepted this revision.Jan 10 2019, 11:32 PM

oh sorry. I was misunderstand this patch.
I've checked current list_view is broken and the root reason is precise_layouter is not written as asyncrous future action on the realized item.
patch works very well, item shows little delay, but still it works,
we have to fixing delay issue after this,
but it looks good to me.

This revision is now accepted and ready to land.Jan 10 2019, 11:32 PM
This revision was automatically updated to reflect the committed changes.