Page MenuHomePhabricator

eo: correctly allow for triggering the same event while the previous one was cancelled.
ClosedPublic

Authored by cedric on Dec 19 2018, 2:05 PM.

Details

Summary

If you are to trigger an event and just cancelled the one being processed, it would just
not propagate any event while it should. The code looks like more like it was forgotten line
or something.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Dec 19 2018, 2:05 PM
cedric requested review of this revision.Dec 19 2018, 2:05 PM

Probably you know what is going on here, so If you say this is OK, I trust you.
To make me less nervous, I would like to have a tests case which was failing before and working after the patch, while other cases continue working undisturbed... But again, if you think the fix is clear and my suggestion is overkill, just ignore it.

Good point, I added a test in the next commit.

bu5hm4n accepted this revision.Dec 20 2018, 11:43 AM
This revision is now accepted and ready to land.Dec 20 2018, 11:43 AM
cedric updated this revision to Diff 18044.Dec 20 2018, 3:08 PM

Rebase.

This revision was automatically updated to reflect the committed changes.