Page MenuHomePhabricator
Differential D7486

ecore: correct object constness and documentation of future_resolved and future_rejected functions.
ClosedPublic
Actions

Authored by cedric on Dec 19 2018, 2:05 PM.

Details

Reviewers
barbieri
felipealmeida
bu5hm4n
woohyun
SanghyeonLee
lauromoura
vitor.sousa
larryolj
segfaultxavi
Maniphest Tasks
T7470: [MVVM] Create a ViewModel helper class
Commits
rEFL07e60713fecb: ecore: correct object constness and documentation of future_resolved and…
Summary

Depends on D7485

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Dec 19 2018, 2:05 PM
cedric requested review of this revision.Dec 19 2018, 2:05 PM
cedric added a child revision: D7487: ecore: add an helper class Efl.Model_View.
segfaultxavi added a subscriber: segfaultxavi.Dec 21 2018, 3:14 AM
segfaultxavi added inline comments.
src/lib/ecore/efl_loop_consumer.eo
25–32

Apparently I missed this when I accepted this patch. future_resolved and future_rejected should be documented. Their parameters and return values too.

Do you mind adding these comments now?

segfaultxavi requested changes to this revision.Dec 24 2018, 3:21 AM

Still missing EO docs for future_resolved and future_rejected (including parameters and return values).

This revision now requires changes to proceed.Dec 24 2018, 3:21 AM
cedric added a comment.Dec 28 2018, 10:26 AM

Oh forgot that. Will fix.

cedric updated this revision to Diff 18148.Dec 28 2018, 11:13 AM
cedric retitled this revision from ecore: correct object constness of future_resolved and future_rejected functions. to ecore: correct object constness and documentation of future_resolved and future_rejected functions..

Rebase and document.

segfaultxavi accepted this revision.Dec 30 2018, 8:47 AM

Some doc references could still be improved, but.... what can't?

This revision is now accepted and ready to land.Dec 30 2018, 8:47 AM
Closed by commit rEFL07e60713fecb: ecore: correct object constness and documentation of future_resolved and… (authored by cedric). · Explain WhyJan 2 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18184

View Options

src/lib/ecore/efl_loop_consumer.c

Loading...
View Options

src/lib/ecore/efl_loop_consumer.eo

Loading...