Page MenuHomePhabricator

eo: test that event cancel before emitting does propagate event.
ClosedPublic

Authored by cedric on Dec 20 2018, 11:31 AM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Dec 20 2018, 11:31 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Dec 20 2018, 11:31 AM

Mhmmm why is that done ? :)

This test is adding a case that trigger a stop before generating a call to a new nested event. This was broken before. If you did call stop after the callback_call, it was working, if you called before, it wouldn't.

Okay, can you move this commit after the actaul fix, of sqash them? (so bisect is not failing on this)

It is just after D7481 which is the commit that fix this problem. So it shouldn't break on bisect.

Yeah - ignore my comment I was confused :)

cedric updated this revision to Diff 18045.Dec 20 2018, 3:08 PM

Rebase.

bu5hm4n accepted this revision.Dec 26 2018, 5:21 AM
This revision is now accepted and ready to land.Dec 26 2018, 5:21 AM
This revision was automatically updated to reflect the committed changes.