Page MenuHomePhabricator
Differential D7496

eo: test that event cancel before emitting does propagate event.
ClosedPublic
Actions

Authored by cedric on Dec 20 2018, 11:31 AM.

Details

Reviewers
felipealmeida
vitor.sousa
lauromoura
bu5hm4n
Maniphest Tasks
T7470: [MVVM] Create a ViewModel helper class
Commits
rEFLe9a434df9b26: eo: test that event cancel before emitting does propagate event.
Summary

Depends on D7481

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Dec 20 2018, 11:31 AM
Herald added subscribers: committers, reviewers. · View Herald TranscriptDec 20 2018, 11:31 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Dec 20 2018, 11:31 AM
cedric added a child revision: D7482: eo: enable priority with event forwarder..
bu5hm4n added a subscriber: bu5hm4n.Dec 20 2018, 11:42 AM

Mhmmm why is that done ? :)

cedric added a comment.Dec 20 2018, 11:50 AM

This test is adding a case that trigger a stop before generating a call to a new nested event. This was broken before. If you did call stop after the callback_call, it was working, if you called before, it wouldn't.

bu5hm4n added a comment.Dec 20 2018, 11:57 AM

Okay, can you move this commit after the actaul fix, of sqash them? (so bisect is not failing on this)

cedric added a comment.Dec 20 2018, 12:00 PM

It is just after D7481 which is the commit that fix this problem. So it shouldn't break on bisect.

bu5hm4n added a comment.Dec 20 2018, 12:10 PM

Yeah - ignore my comment I was confused :)

cedric updated this revision to Diff 18045.Dec 20 2018, 3:08 PM

Rebase.

bu5hm4n accepted this revision.Dec 26 2018, 5:21 AM
This revision is now accepted and ready to land.Dec 26 2018, 5:21 AM
Closed by commit rEFLe9a434df9b26: eo: test that event cancel before emitting does propagate event. (authored by cedric). · Explain WhyJan 2 2019, 1:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/tests/eo/signals/signals_main.c (19 lines)

Diff 18178

View Options

src/tests/eo/signals/signals_main.c

Loading...