Page MenuHomePhabricator

ecore: here comes a command line object
Needs ReviewPublic

Authored by bu5hm4n on Wed, Dec 26, 9:10 AM.

Details

Summary

the mixin for now can carry a command, which can be setted as an string.
The string is then parsed again, this is done in order to make sure that
everything that needs escaping really is escaped or parsed correctly.

Depends on D7514

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/submit
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8666
bu5hm4n created this revision.Wed, Dec 26, 9:10 AM
bu5hm4n requested review of this revision.Wed, Dec 26, 9:10 AM
zmike requested changes to this revision.Wed, Dec 26, 11:01 AM
zmike added a subscriber: billiob.

This should have a couple things prior to landing:

  1. successful travis build results
  2. (many) more tests for command line parsing; @billiob may have some interest/ideas here since terminology likely has done fuzz testing for things like this?
This revision now requires changes to proceed.Wed, Dec 26, 11:01 AM

I completly agree with you, my problem here is, i have not a lot of shell knowledge, i don't really know what needs escapting etc. what is security sensitive, the code there is just copied from efl_task.c (which is untested.)

No autotools support? :(

You may want to escape every char < 0x20 (and write it as \x07). Same for 0x7f (del) and 0xc1, 0xc2 (unicode escape codes).

bu5hm4n planned changes to this revision.Thu, Dec 27, 3:24 AM

I will check it out, thx billiob :)

TODO: more tests escape correct chars

bu5hm4n updated this revision to Diff 18221.Fri, Jan 4, 3:25 AM
bu5hm4n edited the summary of this revision. (Show Details)

buildsystem update