Page MenuHomePhabricator

eo: add a test to enforce the upper limit of our base object size.
ClosedPublic

Authored by cedric on Thu, Dec 27, 4:05 PM.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Thu, Dec 27, 4:05 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

segfaultxavi added a subscriber: segfaultxavi.
segfaultxavi added inline comments.
src/tests/eo/suite/eo_test_general.c
1793

I would add another comment line with something like:
// Update this number only if you modified the class size on purpose

I agree with Xavi that we should add something to the comment when this number can be updated. Or do you consider this upper limit fixed without any exceptions?

zmike added a subscriber: zmike.Tue, Jan 8, 9:35 AM

I agree with Xavi that we should add something to the comment when this number can be updated. Or do you consider this upper limit fixed without any exceptions?

I think it would be ideal if this value could just be calculated in place (using private eo headers) to avoid having to update it. @cedric what do you think about this?

zmike added a comment.Tue, Jan 8, 9:39 AM

After reading comments in D7441 I am changing my opinion; this can't be calculated entirely in place if we want to maintain this test as a time-saving method to avoid unnecessary optimization. Having a comment as @stefan_schmidt suggested would be good, and then we can also easily see if someone changes object sizes since they would have to update the tests.

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 9, 11:02 AM
This revision was automatically updated to reflect the committed changes.