Page MenuHomePhabricator

efl_model : rename all efl_model based classes.
Needs ReviewPublic

Authored by SanghyeonLee on Thu, Jan 3, 3:47 AM.

Details

Summary

As the result of discussion in T7458,
we need to rename all efl_model based classes with efl_XXX_Model sequence.
I've run few vote for this, see V42, V43
few classes are totally renamed as our consideration of misnaming.

Efl.Model_LoopEfl.Loop_Model
Efl.Model_ItemEfl.Generic_Model
Efl.Model_ContainerEfl.Container_Model
Efl.Model_Container_ItemEfl.Container_Model_Item
Efl.Model_CompositeEfl.Composite_Model
Efl.Model_Composite_BooleanEfl.Boolean_Model
Efl.Model_Composite_Boolean_ChlidrenEfl.Boolean_Model_Item
Efl.Model_Composite_SelectionEfl.Select_Model
Efl.Model_Composite_Selection_ChlidrenEfl.Select_Model_Item
Efl.Model_ViewEfl.View_Model
Eio.ModelEfl.Io.Model
Efl.Ui.Model_StateEfl.Ui.State_Model

I worried about Efl.Io.Model changes, cause it is widely used,
but as I tested, there is no issue found yet.

Eldbus.Model also may can changed Efl.Dbus.Model,
but I cannot found any class who using Efl.Dbus namespace,
so I left it future work.

Test Plan

Run the Make Test,
it works well except Efl test about selection.
there are class inheritance problem exist in select_model,
I reported it and will fix it in another patch.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8642
Build 7664: arc lint + arc unit
SanghyeonLee created this revision.Thu, Jan 3, 3:47 AM
SanghyeonLee requested review of this revision.Thu, Jan 3, 3:47 AM
SanghyeonLee edited the summary of this revision. (Show Details)Thu, Jan 3, 3:53 AM

rebasing patch on top of D7529