Page MenuHomePhabricator

e_main: initialise XDG environment earlier.
ClosedPublic

Authored by netstar on Jan 3 2019, 5:24 AM.

Details

Summary

Moving _xdg_data_dirs_augment call to earlier in
initalisation process. Currently first-run will
leave XDG_MENU_PREFIX broken, thus the application
menu will be empty in E.

Seems eio_init might be the culprit.

Moved to above eio_init.

Test Plan
  • Launch E from X from a console (startx)
  • Check application menu (empty).
  • Apply patch.
  • Launch E from X from a console (startx)
  • E's Application menu should be populated.

Related to https://phab.enlightenment.org/D7534

Diff Detail

Repository
rE core/enlightenment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
netstar created this revision.Jan 3 2019, 5:24 AM
netstar requested review of this revision.Jan 3 2019, 5:24 AM
zmike added a comment.Jan 3 2019, 6:35 AM

I am okay with this provided you can determine exactly why this solves the issue and then add a note about it in a comment above the changed line.

netstar updated this revision to Diff 18200.Jan 3 2019, 7:41 AM

Add a comment about the change.

zmike accepted this revision.Jan 3 2019, 9:40 AM

Can you be extra explicit and note that eio_init internally calls efreet_init? Seems good.

This revision is now accepted and ready to land.Jan 3 2019, 9:40 AM
netstar updated this revision to Diff 18202.Jan 3 2019, 10:05 AM

Fix comments.

netstar updated this revision to Diff 18203.Jan 3 2019, 10:06 AM

Fix typo.

This revision was automatically updated to reflect the committed changes.