Page MenuHomePhabricator

efl_ui_win: Load config values into gesture manager.
ClosedPublic

Authored by CHAN on Jan 4 2019, 12:00 AM.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8662
Build 7684: arc lint + arc unit
CHAN created this revision.Jan 4 2019, 12:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Jan 4 2019, 12:00 AM
CHAN edited the summary of this revision. (Show Details)Jan 4 2019, 12:02 AM
CHAN added reviewers: woohyun, smohanty.
CHAN updated this revision to Diff 18216.Jan 4 2019, 12:03 AM

Code claen up.

CHAN edited the summary of this revision. (Show Details)Jan 4 2019, 12:04 AM
zmike added a subscriber: zmike.Jan 9 2019, 9:36 AM

This seems reasonable to me. @woohyun what do you think?

cedric accepted this revision.Jan 9 2019, 12:18 PM
This revision is now accepted and ready to land.Jan 9 2019, 12:18 PM
Jaehyun_Cho accepted this revision.Wed, Jan 23, 10:25 PM
Jaehyun_Cho added a subscriber: Jaehyun_Cho.

I agree with this patch.

@CHAN @cedric
BTW, what do you think about making Efl.Canvas.Gesture_Manager implement Efl.Config to implement Efl.Config.config { get; set;} ?
i.e. In efl_ui_win.c, efl_config_set() is used instead of efl_gesture_manager_config_set().

What do you think about it? Does it have any side effect?

Closed by commit rEFLfe29a7a06db2: efl_ui_win: Load config values into gesture manager. (authored by Woochanlee <wc0917.lee@samsung.com>, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyWed, Jan 30, 4:33 AM
This revision was automatically updated to reflect the committed changes.