Details

Reviewers

SanghyeonLee
raster
stefan_schmidt
zmike
felipealmeida
barbieri
lauromoura

Maniphest Tasks

T7530: Fix eina promise data store

Summary

eina_promise_data_set is a misleading API and result in conflicted use by
multiple independent piece of code leading to bug and crash. It is also not
necessary and we can avoid using it completely.

Diff Detail

Repository

rEFL core/efl

Branch

T7530-devs/cedric/eina_promise_data_set

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8721

cedric created this revision.Fri, Jan 4, 5:59 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptFri, Jan 4, 5:59 PM

cedric requested review of this revision.Fri, Jan 4, 5:59 PM

Harbormaster completed remote builds in B8672: Diff 18229.Fri, Jan 4, 5:59 PM

Harbormaster completed remote builds in B8674: Diff 18232.Fri, Jan 4, 6:01 PM

Harbormaster completed remote builds in B8677: Diff 18236.

Harbormaster completed remote builds in B8678: Diff 18238.Fri, Jan 4, 6:02 PM

Can you add a small amount of detail to the commit logs for this entire stack so that there is some explanation in case we ever need to know what you were thinking when you wrote this series?

Rebase and reword.

Harbormaster completed remote builds in B8721: Diff 18296.Wed, Jan 9, 3:09 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18229	efd0efb		Fri, Jan 4, 5:59 PM	★	★
Diff 2	18232	efd0efb		Fri, Jan 4, 6:00 PM	★	★
Diff 3	18236	efd0efb		Fri, Jan 4, 6:01 PM	★	★
Diff 4	18238	efd0efb		Fri, Jan 4, 6:01 PM	★	★
Diff 5	18296	8e85e19	Rebase and reword.	Wed, Jan 9, 3:09 PM	★	★

Status	Author	Revision
Abandoned	cedric	D7553 eina: move eina_promise_data_get to internal usage only.
Abandoned	cedric	D7552 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Abandoned	cedric	D7551 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Abandoned	cedric	D7550 eina: remove eina_promise_data_set.
Abandoned	cedric	D7549 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Abandoned	cedric	D7548 Revert "fix crashes created by "make efl_loop_promise_new a function""
Abandoned	cedric	D7547 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7578 eina: move eina_promise_data_get to internal usage only.
Needs Review	cedric	D7577 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Needs Review	cedric	D7576 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Needs Review	cedric	D7575 eina: remove eina_promise_data_set.
Needs Review	cedric	D7574 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Needs Review	cedric	D7573 Revert "fix crashes created by "make efl_loop_promise_new a function""
Needs Review	cedric	D7572 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7545 ecore_con: remove use of eina_promise_data_set.
Accepted	cedric	D7544 ecore: make Efl.Loop_Consumer.promise_new an @const function.
Needs Review	cedric	D7543 elementary: refactor selection manager to not use eina_promise_data_set.

elementary: refactor selection manager to not use eina_promise_data_set.
Needs ReviewPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 18296

src/lib/elementary/efl_ui_selection_manager.c

elementary: refactor selection manager to not use eina_promise_data_set.Needs ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 18296

src/lib/elementary/efl_ui_selection_manager.c

elementary: refactor selection manager to not use eina_promise_data_set.
Needs ReviewPublic
Actions

Revision Contents
Changeset List