Page MenuHomePhabricator
Differential D7544

ecore: make Efl.Loop_Consumer.promise_new an @const function.
ClosedPublic
Actions

Authored by cedric on Jan 4 2019, 5:59 PM.

Details

Reviewers
SanghyeonLee
raster
stefan_schmidt
zmike
felipealmeida
barbieri
lauromoura
segfaultxavi
Maniphest Tasks
T7530: Fix eina promise data store
Commits
rEFL4e4176c84c3b: ecore: make Efl.Loop_Consumer.promise_new an @const function.
Summary

Depends on D7543

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 4 2019, 5:59 PM
cedric requested review of this revision.Jan 4 2019, 5:59 PM
cedric updated this revision to Diff 18233.
segfaultxavi accepted this revision.Jan 7 2019, 8:04 AM
segfaultxavi added a subscriber: segfaultxavi.

It builds, so no objection.

However you are again submitting a long list of unrelated patches in a single stack, which makes review and acceptance cumbersome :)

This revision is now accepted and ready to land.Jan 7 2019, 8:04 AM
cedric updated this revision to Diff 18297.Jan 9 2019, 3:09 PM

Rebase and reword.

cedric updated this revision to Diff 18483.Jan 16 2019, 9:45 AM

Rebase.

zmike accepted this revision.Jan 16 2019, 10:45 AM
Closed by commit rEFL4e4176c84c3b: ecore: make Efl.Loop_Consumer.promise_new an @const function. (authored by cedric). · Explain WhyJan 16 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18494

View Options

src/lib/ecore/efl_loop_consumer.c

Loading...
View Options

src/lib/ecore/efl_loop_consumer.eo

Loading...