Page MenuHomePhabricator
Differential D7545

ecore_con: remove use of eina_promise_data_set.
ClosedPublic
Actions

Authored by cedric on Jan 4 2019, 6:00 PM.

Details

Reviewers
SanghyeonLee
raster
stefan_schmidt
zmike
felipealmeida
barbieri
lauromoura
Maniphest Tasks
T7530: Fix eina promise data store
Commits
rEFL54729224672d: ecore_con: remove use of eina_promise_data_set.
Summary

eina_promise_data_set is a misleading API and result in conflicted use by
multiple independent piece of code leading to bug and crash. It is also not
necessary and we can avoid using it completely.

Depends on D7544

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 4 2019, 6:00 PM
cedric requested review of this revision.Jan 4 2019, 6:00 PM
cedric updated this revision to Diff 18298.Jan 9 2019, 3:09 PM
cedric edited the summary of this revision. (Show Details)

Rebase and reword.

cedric updated this revision to Diff 18484.Jan 16 2019, 9:45 AM

Rebase.

zmike accepted this revision.Jan 16 2019, 10:51 AM
This revision is now accepted and ready to land.Jan 16 2019, 10:51 AM
Closed by commit rEFL54729224672d: ecore_con: remove use of eina_promise_data_set. (authored by cedric). · Explain WhyJan 16 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18495

View Options

src/lib/ecore_con/efl_net_control_technology-connman.c

Loading...