ecore_con: remove use of eina_promise_data_set.
Needs ReviewPublic
Actions

Authored by cedric on Fri, Jan 4, 6:00 PM.

Details

Reviewers

SanghyeonLee
raster
stefan_schmidt
zmike
felipealmeida
barbieri
lauromoura

Maniphest Tasks

T7530: Fix eina promise data store

Summary

eina_promise_data_set is a misleading API and result in conflicted use by
multiple independent piece of code leading to bug and crash. It is also not
necessary and we can avoid using it completely.

Depends on D7544

Diff Detail

Repository

rEFL core/efl

Branch

T7530-devs/cedric/eina_promise_data_set

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8723

cedric created this revision.Fri, Jan 4, 6:00 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptFri, Jan 4, 6:00 PM

cedric requested review of this revision.Fri, Jan 4, 6:00 PM

Harbormaster completed remote builds in B8676: Diff 18234.Fri, Jan 4, 6:01 PM

cedric added a child revision: D7547: eio: remove use of eina_promise_data_set..Fri, Jan 4, 6:02 PM

Harbormaster completed remote builds in B8680: Diff 18240.Fri, Jan 4, 6:07 PM

Rebase and reword.

Harbormaster completed remote builds in B8723: Diff 18298.Wed, Jan 9, 3:09 PM

cedric added a child revision: D7572: eio: remove use of eina_promise_data_set..Wed, Jan 9, 3:09 PM

Revision Contents
Changeset List

			Path	Packages
~			src/lib/ecore_con/efl_net_control_technology-connman.c (43 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18234	f02edc4		Fri, Jan 4, 6:00 PM	★	★
Diff 2	18240	0b7cce3		Fri, Jan 4, 6:02 PM	★	★
Diff 3	18298	6d06527	Rebase and reword.	Wed, Jan 9, 3:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
433525a56c5c	066f6235701a	6d06527e9c6d	Cedric BAIL	(Show More…)	Fri, Jan 4, 4:01 PM

Status	Author	Revision
Abandoned	cedric	D7553 eina: move eina_promise_data_get to internal usage only.
Abandoned	cedric	D7552 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Abandoned	cedric	D7551 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Abandoned	cedric	D7550 eina: remove eina_promise_data_set.
Abandoned	cedric	D7549 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Abandoned	cedric	D7548 Revert "fix crashes created by "make efl_loop_promise_new a function""
Abandoned	cedric	D7547 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7578 eina: move eina_promise_data_get to internal usage only.
Needs Review	cedric	D7577 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Needs Review	cedric	D7576 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Needs Review	cedric	D7575 eina: remove eina_promise_data_set.
Needs Review	cedric	D7574 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Needs Review	cedric	D7573 Revert "fix crashes created by "make efl_loop_promise_new a function""
Needs Review	cedric	D7572 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7545 ecore_con: remove use of eina_promise_data_set.
Accepted	cedric	D7544 ecore: make Efl.Loop_Consumer.promise_new an @const function.
Needs Review	cedric	D7543 elementary: refactor selection manager to not use eina_promise_data_set.

Diff 18298

View Options

src/lib/ecore_con/efl_net_control_technology-connman.c