ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
AbandonedPublic
Actions

Authored by cedric on Jan 4 2019, 6:03 PM.

Details

Reviewers

SanghyeonLee
raster
stefan_schmidt
zmike
felipealmeida
barbieri
lauromoura

Maniphest Tasks

T7530: Fix eina promise data store

Summary

If you need data, use a efl_future_then as done in every case here to get the same feature.
Depends on D7551

Diff Detail

Repository

rEFL core/efl

Branch

T7530-devs/cedric/eina_promise_data_set

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8686

cedric created this revision.Jan 4 2019, 6:03 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptJan 4 2019, 6:03 PM

cedric requested review of this revision.Jan 4 2019, 6:03 PM

cedric added a child revision: D7553: eina: move eina_promise_data_get to internal usage only..

Harbormaster completed remote builds in B8686: Diff 18246.Jan 4 2019, 6:07 PM

After a nice fail of git phab attach, you can find this patch as D7577.

Revision Contents
Changeset List

			Path	Packages
~			src/examples/ecore/ecore_promise2_example.c (12 lines)
~			src/lib/ecore/efl_exe.c (25 lines)
~			src/lib/ecore/efl_loop_consumer.c (40 lines)
~			src/lib/ecore/efl_loop_consumer.eo (11 lines)
~			src/lib/ecore/efl_thread.c (21 lines)
~			src/lib/ecore_con/efl_net_control_access_point-connman.c (36 lines)
~			src/lib/ecore_con/efl_net_control_technology-connman.c (2 lines)
~			src/lib/eio/efl_io_manager.c (18 lines)
~			src/lib/eio/eio_model.c (18 lines)
~			src/lib/eldbus/eldbus_model_connection.c (2 lines)
~			src/lib/eldbus/eldbus_model_object.c (2 lines)
~			src/lib/eldbus/eldbus_model_private.h (7 lines)
~			src/lib/eldbus/eldbus_model_proxy.c (11 lines)
~			src/lib/elementary/efl_ui_selection_manager.c (2 lines)

Commit	Tree	Parents	Author	Summary	Date
7137a86a853b	b8d59746a8a8	e836fc60e0b8	Cedric BAIL	(Show More…)	Jan 4 2019, 5:42 PM

Status	Author	Revision
Closed	cedric	D7578 eina: remove eina_promise_data_get has it lead to risky use.
Closed	cedric	D7577 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Closed	cedric	D7576 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Closed	cedric	D7575 eina: remove eina_promise_data_set.
Closed	cedric	D7574 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Closed	cedric	D7573 Revert "fix crashes created by "make efl_loop_promise_new a function""
Closed	cedric	D7572 eio: remove use of eina_promise_data_set.
Abandoned	cedric	D7553 eina: move eina_promise_data_get to internal usage only.
Abandoned	cedric	D7552 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Abandoned	cedric	D7551 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Abandoned	cedric	D7550 eina: remove eina_promise_data_set.
Abandoned	cedric	D7549 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Abandoned	cedric	D7548 Revert "fix crashes created by "make efl_loop_promise_new a function""
Abandoned	cedric	D7547 eio: remove use of eina_promise_data_set.
Closed	cedric	D7545 ecore_con: remove use of eina_promise_data_set.
Closed	cedric	D7544 ecore: make Efl.Loop_Consumer.promise_new an @const function.
Closed	cedric	D7543 elementary: refactor selection manager to not use eina_promise_data_set.