Page MenuHomePhabricator

elementary genlist: make it sure object type.
ClosedPublic

Authored by Hermet on Jan 8 2019, 2:47 AM.

Details

Summary

elm has some cases that resize_obj is not the group object.
That case, efl_canvas_group_need_recalculate_get() prints
annoying type-check errors.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Hermet created this revision.Jan 8 2019, 2:47 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Hermet requested review of this revision.Jan 8 2019, 2:47 AM
SanghyeonLee accepted this revision.Jan 8 2019, 2:50 AM

It looks good to me.
the reason of recursive call of widget calculation is to get final calculated size of sub-groups, so non-group-object case need to be skipped.

This revision is now accepted and ready to land.Jan 8 2019, 2:50 AM
This revision was automatically updated to reflect the committed changes.