Page MenuHomePhabricator

mixer: Add sink_input association on client add event
ClosedPublic

Authored by michael.bouchaud on Jan 8 2019, 3:29 AM.

Details

Summary

As the pulseaudio sink could be created before the window, we list
sink_inputs from pulseaudio on client add event. This make to not miss
an association and provide the volume control feature as expected.

Diff Detail

Repository
rE core/enlightenment
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michael.bouchaud requested review of this revision.Jan 8 2019, 3:29 AM
zmike added a comment.Jan 8 2019, 7:28 AM

Child windows are blocked here for what reason?

michael.bouchaud added a comment.EditedJan 8 2019, 7:47 AM

Child are blocked as to respect the current implementation.
I think at time I did this, I have blocked the child to not displaying volume control on popup and other secondary window.
No doubt I blocked this after experimenting some media apps and find it annoying for the user.
Sadly don't remember which one.

zmike accepted this revision.Jan 8 2019, 9:17 AM

Okay, just wondering.

This revision is now accepted and ready to land.Jan 8 2019, 9:17 AM
Closed by commit rE4cc4260c428f: mixer: Add sink_input association on client add event (authored by Michael Bouchaud (yoz) <yoz@efl.so>). · Explain WhyJan 10 2019, 2:34 AM
This revision was automatically updated to reflect the committed changes.