Page MenuHomePhabricator

meson: modify options for enabling the bindings
ClosedPublic

Authored by akanad on Wed, Jan 9, 12:03 AM.

Details

Summary

bindings are added as subdir by foreaching a array defined in meson.build at root.
then meson checks a option which has the same name of the binding.
this patch appends a new option for selecting bindings to build.

[howto]
*as-is
meson build.asis/ -Dmono=false -Dcxx=true
ninja -C build.asis/

*to-be
menson build.tobe/ -Dbindings=luajit,cxx
ninja -C build.tobe/

it is imposibble to use this wrongly because meson raise a error if arguments are not in a predefined list that described in meson_options.txt.
for more information, refer to https://mesonbuild.com/Build-options.html and also take a look at meson_options.txt please.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Wed, Jan 9, 12:03 AM
akanad requested review of this revision.Wed, Jan 9, 12:03 AM
akanad updated this revision to Diff 18268.Wed, Jan 9, 12:16 AM

removes code which is not related with this patch.

akanad updated this revision to Diff 18273.Wed, Jan 9, 1:31 AM

disable 'mono' as default

You are changing the way meson is configured. Please provide a description of what has changed so people unfamiliar with meson does not have to read the file and learn what it all means.
For example:
Instead of meson -Dmono=true -Dcxx=true you now have to use meson -Dbindings=mono,cxx

akanad added a comment.Wed, Jan 9, 6:23 AM

You are changing the way meson is configured. Please provide a description of what has changed so people unfamiliar with meson does not have to read the file and learn what it all means.
For example:
Instead of meson -Dmono=true -Dcxx=true you now have to use meson -Dbindings=mono,cxx

Thanks for your comment.
Would you please let me know a place that I can refer to for modifying a way it describes how to use meson on efl as you said like meson -Dmono=true -Dcxx=true?
or did you mean that I have to describe it on the commit message?

akanad updated this revision to Diff 18277.Wed, Jan 9, 6:27 AM

modify a script for ci service

akanad updated this revision to Diff 18278.Wed, Jan 9, 6:36 AM
akanad edited the summary of this revision. (Show Details)

update the commit message

Thanks, that is exactly what I meant :)

bu5hm4n accepted this revision.Wed, Jan 9, 11:36 AM
This revision is now accepted and ready to land.Wed, Jan 9, 11:36 AM

https://travis-ci.org/Enlightenment/efl/builds/477505958 this and the 3 other accepted patches are buildtested there.

Closed by commit rEFL8d58ef48bdad: meson: modify options for enabling the bindings (authored by WhiskyKiloSq, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyThu, Jan 10, 3:14 AM
This revision was automatically updated to reflect the committed changes.