Page MenuHomePhabricator

meson: fix a potentionally unexpected behavior
ClosedPublic

Authored by akanad on Jan 9 2019, 1:21 AM.

Details

Summary

lidrm is defined in different locations, which causes a unexpected behavior.
this patch fixes it in advance.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Jan 9 2019, 1:21 AM
akanad requested review of this revision.Jan 9 2019, 1:21 AM
bu5hm4n requested changes to this revision.Jan 9 2019, 11:33 AM

Mhmm i would rather prefer assigning those variables in the root meson.build dir, so the location of the variable is at a shared root node.

This revision now requires changes to proceed.Jan 9 2019, 11:33 AM

Mhmm i would rather prefer assigning those variables in the root meson.build dir, so the location of the variable is at a shared root node.

I don't get a point that you said. you mean that lib*** variables should be assigned in root meson.build?

akanad updated this revision to Diff 18311.Jan 9 2019, 11:55 PM

'libdrm' variable is overwritten by assigning in different places.
because the var has been already declared in static_libs/libdrm.
and also it seems like if-statements have some reduntdant points.

bu5hm4n accepted this revision.Jan 10 2019, 1:31 AM
This revision is now accepted and ready to land.Jan 10 2019, 1:31 AM

Thx :)

Appreciate for your good opinion : )

Closed by commit rEFL2ce974475450: meson: fix a potentionally unexpected behavior (authored by WhiskyKiloSq, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 10 2019, 3:14 AM
This revision was automatically updated to reflect the committed changes.