eio: remove use of eina_promise_data_set.
Needs ReviewPublic
Actions

Authored by cedric on Wed, Jan 9, 3:09 PM.

Details

Reviewers: None
Maniphest Tasks: T7530: Fix eina promise data store

Summary

eina_promise_data_set is a misleading API and result in conflicted use by
multiple independent piece of code leading to bug and crash. It is also not
necessary and we can avoid using it completely.
Depends on D7545

Diff Detail

Repository

rEFL core/efl

Branch

T7530-devs/cedric/eina_promise_data_set

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8724

cedric created this revision.Wed, Jan 9, 3:09 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Wed, Jan 9, 3:09 PM

cedric added a child revision: D7573: Revert "fix crashes created by "make efl_loop_promise_new a function"".

Harbormaster completed remote builds in B8724: Diff 18299.Wed, Jan 9, 3:11 PM

cedric mentioned this in D7547: eio: remove use of eina_promise_data_set..Wed, Jan 9, 3:13 PM

Revision Contents
Changeset List

			Path	Packages
~			src/lib/eio/efl_io_manager.c (46 lines)
~			src/lib/eio/eio_model.c (23 lines)
~			src/lib/eio/eio_private.h (16 lines)

Commit	Tree	Parents	Author	Summary	Date
70005f51c444	6dbb29106f3a	433525a56c5c	Cedric BAIL	(Show More…)	Fri, Jan 4, 4:01 PM

Status	Author	Revision
Abandoned	cedric	D7553 eina: move eina_promise_data_get to internal usage only.
Abandoned	cedric	D7552 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Abandoned	cedric	D7551 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Abandoned	cedric	D7550 eina: remove eina_promise_data_set.
Abandoned	cedric	D7549 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Abandoned	cedric	D7548 Revert "fix crashes created by "make efl_loop_promise_new a function""
Abandoned	cedric	D7547 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7578 eina: move eina_promise_data_get to internal usage only.
Needs Review	cedric	D7577 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Needs Review	cedric	D7576 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Needs Review	cedric	D7575 eina: remove eina_promise_data_set.
Needs Review	cedric	D7574 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Needs Review	cedric	D7573 Revert "fix crashes created by "make efl_loop_promise_new a function""
Needs Review	cedric	D7572 eio: remove use of eina_promise_data_set.
Needs Review	cedric	D7545 ecore_con: remove use of eina_promise_data_set.
Accepted	cedric	D7544 ecore: make Efl.Loop_Consumer.promise_new an @const function.
Needs Review	cedric	D7543 elementary: refactor selection manager to not use eina_promise_data_set.

Diff 18299

View Options

src/lib/eio/efl_io_manager.c

View Options

src/lib/eio/eio_model.c

View Options

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18299	433525a		Wed, Jan 9, 3:09 PM	★	★

eio: remove use of eina_promise_data_set.Needs ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 18299

src/lib/eio/efl_io_manager.c

src/lib/eio/eio_model.c

src/lib/eio/eio_private.h

eio: remove use of eina_promise_data_set.
Needs ReviewPublic
Actions

Revision Contents
Changeset List