Differential D7572

eio: remove use of eina_promise_data_set.
ClosedPublic
Actions

Authored by cedric on Jan 9 2019, 3:09 PM.

Details

Reviewers

zmike

Maniphest Tasks

T7530: Fix eina promise data store

Commits

rEFL04090f3e7ace: eio: remove use of eina_promise_data_set.

Summary

eina_promise_data_set is a misleading API and result in conflicted use by
multiple independent piece of code leading to bug and crash. It is also not
necessary and we can avoid using it completely.

Depends on D7545

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

cedric created this revision.Jan 9 2019, 3:09 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Jan 9 2019, 3:09 PM

cedric added a child revision: D7573: Revert "fix crashes created by "make efl_loop_promise_new a function"".

Harbormaster completed remote builds in B8724: Diff 18299.Jan 9 2019, 3:11 PM

cedric mentioned this in D7547: eio: remove use of eina_promise_data_set..Jan 9 2019, 3:13 PM

Rebase.

Harbormaster completed remote builds in B8856: Diff 18485.Jan 16 2019, 9:46 AM

zmike accepted this revision.Jan 16 2019, 10:53 AM

This revision is now accepted and ready to land.Jan 16 2019, 10:53 AM

Closed by commit rEFL04090f3e7ace: eio: remove use of eina_promise_data_set. (authored by cedric). · Explain WhyJan 16 2019, 2:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/eio/efl_io_manager.c (46 lines)
M			src/lib/eio/eio_model.c (23 lines)
M			src/lib/eio/eio_private.h (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18299	433525a		Jan 9 2019, 3:09 PM	★	★
Diff 2	18485	feca5fe	Rebase.	Jan 16 2019, 9:45 AM	★	★
Diff 3	18497	5472922	rEFL04090f3e7acef5ca47b7b44033dbf3312ae8b6d1	Jan 16 2019, 2:33 PM	★	★

Status	Author	Revision
Abandoned	cedric	D7553 eina: move eina_promise_data_get to internal usage only.
Abandoned	cedric	D7552 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Abandoned	cedric	D7551 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Abandoned	cedric	D7550 eina: remove eina_promise_data_set.
Abandoned	cedric	D7549 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Abandoned	cedric	D7548 Revert "fix crashes created by "make efl_loop_promise_new a function""
Abandoned	cedric	D7547 eio: remove use of eina_promise_data_set.
Closed	cedric	D7578 eina: remove eina_promise_data_get has it lead to risky use.
Closed	cedric	D7577 ecore: remove data parameters of Efl.Loop_Consumer.promise_new to reduce the risk of inadvertently using the wrong data.
Closed	cedric	D7576 eina_cxx: allow for the generation of function that return Eina_Promise in .eo files.
Closed	cedric	D7575 eina: remove eina_promise_data_set.
Closed	cedric	D7574 Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
Closed	cedric	D7573 Revert "fix crashes created by "make efl_loop_promise_new a function""
Closed	cedric	D7572 eio: remove use of eina_promise_data_set.
Closed	cedric	D7545 ecore_con: remove use of eina_promise_data_set.
Closed	cedric	D7544 ecore: make Efl.Loop_Consumer.promise_new an @const function.
Closed	cedric	D7543 elementary: refactor selection manager to not use eina_promise_data_set.

Diff 18497

View Options

src/lib/eio/efl_io_manager.c

View Options

src/lib/eio/eio_model.c

View Options

eio: remove use of eina_promise_data_set.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 18497

src/lib/eio/efl_io_manager.c

src/lib/eio/eio_model.c

src/lib/eio/eio_private.h

eio: remove use of eina_promise_data_set.
ClosedPublic
Actions

Revision Contents
Changeset List