Page MenuHomePhabricator
Differential D7573

Revert "fix crashes created by "make efl_loop_promise_new a function""
ClosedPublic
Actions

Authored by cedric on Jan 9 2019, 3:09 PM.

Details

Reviewers
zmike
Maniphest Tasks
T7530: Fix eina promise data store
Commits
rEFLd67a7df9caad: Revert "fix crashes created by "make efl_loop_promise_new a function""
Summary

This serie of patch didn't address the core problem in the design of the
ownership of eina_promise_data_{set/get} usage. It is also redundant with
other infrastructure in eina_promise and so not necessary completely.

This reverts commit de2ec0559b01dba7919503955cc47c1c5fcd0f97.

Depends on D7572

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 9 2019, 3:09 PM
Herald added subscribers: committers, reviewers. · View Herald TranscriptJan 9 2019, 3:09 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric updated this revision to Diff 18486.Jan 16 2019, 9:46 AM
cedric edited the summary of this revision. (Show Details)

Rebase.

zmike accepted this revision.Jan 16 2019, 10:56 AM
zmike added a subscriber: zmike.

eina_promise_data_free_cb_set_cb_set is some real function gore...

This revision is now accepted and ready to land.Jan 16 2019, 10:56 AM
Closed by commit rEFLd67a7df9caad: Revert "fix crashes created by "make efl_loop_promise_new a function"" (authored by cedric). · Explain WhyJan 16 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18498

View Options

src/lib/ecore/efl_loop_consumer.c

Loading...
View Options

src/lib/eina/eina_promise.h

Loading...
View Options

src/lib/eina/eina_promise.c

Loading...