Page MenuHomePhabricator
Differential D7574

Revert "eina: add a function to free Eina_Promise attached data when the promise is destroyed."
ClosedPublic
Actions

Authored by cedric on Jan 9 2019, 3:10 PM.

Details

Reviewers
zmike
Maniphest Tasks
T7530: Fix eina promise data store
Commits
rEFLb3d04f72008f: Revert "eina: add a function to free Eina_Promise attached data when the…
Summary

A better solution is to actually have no eina_promise_data_set/get at all.

This reverts commit ce56f32270c2f75adab022b701d3bdcbbbc3fb44.

Depends on D7573

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 9 2019, 3:10 PM
Herald added subscribers: committers, reviewers. · View Herald TranscriptJan 9 2019, 3:10 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Jan 9 2019, 3:10 PM
cedric added a child revision: D7575: eina: remove eina_promise_data_set..
cedric updated this revision to Diff 18487.Jan 16 2019, 9:47 AM
cedric edited the summary of this revision. (Show Details)

Rebase.

zmike accepted this revision.Jan 16 2019, 10:58 AM
This revision is now accepted and ready to land.Jan 16 2019, 10:58 AM
Closed by commit rEFLb3d04f72008f: Revert "eina: add a function to free Eina_Promise attached data when the… (authored by cedric). · Explain WhyJan 16 2019, 2:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18499

View Options

src/lib/eina/eina_promise.h

Loading...
View Options

src/lib/eina/eina_promise.c

Loading...