Page MenuHomePhabricator

eina: remove eina_promise_data_get has it lead to risky use.
ClosedPublic

Authored by cedric on Jan 9 2019, 3:10 PM.

Details

Summary

It seems that use of eina_promise_data_get lead to mostly missuse. As it
duplicate other infrastructure which do not have the same problem. So better
remove it and if we need it back, we can just revert this patch later.

Depends on D7577

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 9 2019, 3:10 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

cedric requested review of this revision.Jan 9 2019, 3:10 PM
cedric updated this revision to Diff 18491.Jan 16 2019, 9:50 AM
cedric edited the summary of this revision. (Show Details)

Rebase.

zmike added a subscriber: zmike.Jan 16 2019, 10:26 AM

This seems sensible based on how suboptimal existing usages of the function have been, but I think it would be better to just remove it now in order to avoid future issues?

zmike requested changes to this revision.Jan 16 2019, 10:29 AM
This revision now requires changes to proceed.Jan 16 2019, 10:29 AM
In D7578#134695, @zmike wrote:

This seems sensible based on how suboptimal existing usages of the function have been, but I think it would be better to just remove it now in order to avoid future issues?

Ok, the removal patch could always be reverted if every useful I guess.

Yeah that's my thought. As long as it's in tree then people can (and probably will) abuse it.

cedric updated this revision to Diff 18496.Jan 16 2019, 2:33 PM
cedric retitled this revision from eina: move eina_promise_data_get to internal usage only. to eina: remove eina_promise_data_get has it lead to risky use..
cedric edited the summary of this revision. (Show Details)

Change commit to actually remove eina_promise_data_get

zmike accepted this revision.Jan 16 2019, 2:36 PM
This revision is now accepted and ready to land.Jan 16 2019, 2:36 PM
This revision was automatically updated to reflect the committed changes.