Page MenuHomePhabricator

Gesture Manager: Add gestures and fix gesture managing, recognizer logic.
Needs RevisionPublic

Authored by CHAN on Thu, Jan 10, 1:16 AM.

Details

Summary

https://phab.enlightenment.org/T7544

Provides a way for a user to get a gesture manager, recognizer instance.

Supports different recognizer properties for each target(Eo).

Gesture, Touch Class Life-cycle re-implementation. for supporting multiple touches.

Add below gestures.
efl_canvas_gesture_tap
efl_canvas_gesture_double_tap
efl_canvas_gesture_triple_tap
efl_canvas_gesture_long_tap
efl_canvas_gesture_momentum
efl_canvas_gesture_zoom
efl_canvas_gesture_flick

Test Plan

Simple test -> test_gesture_framework.c
More test cases will upload.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8737
Build 7714: arc lint + arc unit
CHAN created this revision.Thu, Jan 10, 1:16 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

CHAN requested review of this revision.Thu, Jan 10, 1:16 AM
CHAN edited the summary of this revision. (Show Details)Thu, Jan 10, 1:22 AM
CHAN edited the test plan for this revision. (Show Details)
CHAN added reviewers: woohyun, smohanty.
segfaultxavi requested changes to this revision.Thu, Jan 10, 2:48 AM
segfaultxavi added a subscriber: segfaultxavi.

Several missing docs. Please mark each inline comment as done as you fix them so none is forgotten.

src/lib/evas/gesture/efl_canvas_gesture_double_tap.eo
3

Shouldn't it be "EFL Gesture Double Tap class"?

Also, what's the purpose of this class? Objects emitting Double-tap events inherit from it? Then this should be explained here. Same thing for all other gesture classes.

Also, what is a "double tap"? This deserves at least a one-line explanation: "A double tap is two taps in quick succession." Is the time between taps configurable? If not, how much time is it?

5

Is this eo_prefix correct?

src/lib/evas/gesture/efl_canvas_gesture_long_tap.eo
3

How long must be a tap for it to be considered "long"? Is it configurable?

8

Event for the Long tap gesture.

src/lib/evas/gesture/efl_canvas_gesture_manager.eo
19

Missing docs for the method and its parameter and return value.

src/lib/evas/gesture/efl_canvas_gesture_recognizer_double_tap.eo
6

Docs (properties, keys, values) and indentation!

src/lib/evas/gesture/efl_canvas_gesture_recognizer_long_tap.eo
6

Docs for property, keys and values!

src/lib/evas/gesture/efl_canvas_gesture_recognizer_tap.eo
3

Please explain how this class is used (also the other gesture recognizer classes).

This revision now requires changes to proceed.Thu, Jan 10, 2:48 AM