Page MenuHomePhabricator

eolian: introduce the keyword required
ClosedPublic

Authored by bu5hm4n on Jan 10 2019, 7:21 AM.

Details

Summary

This introduces a new keyword called required. It only works on mixins.
You can specify a list of regular/abstract classes in there.
Classes specified after the required keyword are later used to verify
the usage of the mixin. With this feature a mixin can define a list of
types that the inheriting object (the object that inherits from a mixin)
needs to fullfill, if one class that is required is not in the
implemented classes, then eolian will bail out.

Test Plan

ninja test

Diff Detail

Repository
rEFL core/efl
Branch
devs/bu5hm4n/eolian-mixins-fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8743
bu5hm4n created this revision.Jan 10 2019, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Jan 10 2019, 7:21 AM
bu5hm4n edited the test plan for this revision. (Show Details)Jan 10 2019, 7:23 AM
q66 requested changes to this revision.Jan 10 2019, 7:46 AM

Besides that one thing, looks good to me, I think.

src/lib/eolian/eo_parser.c
2018

this variable is not being free'd, it's a regular malloc'd data so you can free() it.

This revision now requires changes to proceed.Jan 10 2019, 7:46 AM
bu5hm4n updated this revision to Diff 18330.Jan 10 2019, 7:59 AM

fix free

q66 accepted this revision.Jan 10 2019, 8:03 AM

👍

This revision is now accepted and ready to land.Jan 10 2019, 8:03 AM
Closed by commit rEFL455dedd49dd5: eolian: introduce the keyword required (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 11 2019, 3:40 AM
This revision was automatically updated to reflect the committed changes.