Page MenuHomePhabricator

efl: refactor regular class inheriting mixins
ClosedPublic

Authored by bu5hm4n on Thu, Jan 10, 7:21 AM.

Details

Summary

This fixes the mutli class inheritance that caused problems in T7240.

The reson it fixes those problems is that the require keyword does not imply that the required classes are directly inherited, but rather by the user of the mixin later. Thus it is safe to use the functions anyways in the implements {...} section.

With this stack, we don't need any further mixin refactoring.

ref T7240

Depends on D7584

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Thu, Jan 10, 7:21 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Thu, Jan 10, 7:21 AM
bu5hm4n edited the summary of this revision. (Show Details)Thu, Jan 10, 7:26 AM
bu5hm4n edited the summary of this revision. (Show Details)
bu5hm4n retitled this revision from efl: refactor all mixins to efl: refactor regular class inheriting mixins.Thu, Jan 10, 7:29 AM
felipealmeida accepted this revision.Thu, Jan 10, 10:49 AM
This revision is now accepted and ready to land.Thu, Jan 10, 10:49 AM
cedric accepted this revision.Thu, Jan 10, 10:56 AM

I find this solution excellent! Great idea!

Closed by commit rEFL3ddd577fb0c6: efl: refactor all mixins (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyFri, Jan 11, 3:40 AM
This revision was automatically updated to reflect the committed changes.