Page MenuHomePhabricator

Exactness: porting to Meson
Needs ReviewPublic

Authored by JackDanielZ on Jan 10 2019, 12:45 PM.

Details

Summary

Depends on D7590

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 11935
JackDanielZ created this revision.Jan 10 2019, 12:45 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

JackDanielZ requested review of this revision.Jan 10 2019, 12:45 PM

This is a patch which is a part of the integration of Exactness into EFL. D7590 is the code importation into the tree. This patch is the integration into meson.

Soon the part of the 'make check'. I plan to use 'ninja test' and an option to enable it only if wanted. Is it ok? Do you know if there is a way to extract the -j flag so I can give it to Exactness? In autotools, I was using MAKE_FLAGS. Is there an equivalent in meson?

Please merge into D7590 to make it a buildable patch. The integration into nin ja test can come as separate commit.

@bu5hm4n, any good tips for the parallel jobs passing? Ninja does not use -j the same way make does. As far as I can see meson test does execute all tests in parallel. The problem here is that exactness would be only one test in the view of meson but it would run a lot tests on its own.
https://github.com/mesonbuild/meson/blob/master/docs/markdown/Unit-tests.md

stefan_schmidt requested changes to this revision.Jan 16 2019, 6:06 AM
This revision now requires changes to proceed.Jan 16 2019, 6:06 AM

Something seems wrong here. When I build and install efl I have the exactness binaries around but they fail to execute:
exactness: error while loading shared libraries: libexactness.so.1: cannot open shared object file: No such file or directory

Hi Stefan,

What you tell now is weird. I compiled all after having removed my installation and it works well. Maybe it needs ldconfig?

Daniel

zmike updated this revision to Diff 22943.Jun 24 2019, 9:13 AM
zmike added a subscriber: zmike.