Page MenuHomePhabricator

efl_mono: remove '_' from type for C# naming convention
ClosedPublic

Authored by Jaehyun_Cho on Jan 10 2019, 11:53 PM.

Details

Summary

"type" in .eo is converted to "struct" in .eo.cs.
Since the type name in .eo is the same with the struct name .eo.cs,
'_' is removed from the converted struct in .eo.cs for C# naming
convention.

For example, Efl.Callback_Priority is defined in efl_object.eo and
the name is converted to Efl.CallbackPriority in efl_object.eo.cs.

Efl.Access.StateSet in workaround.cs causes duplicated definition
with this patch so Efl.Access.StateSet in workaround.cs is removed.

Test Plan

Compile with autogen.sh --enable-csharp-bindings

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Jaehyun_Cho created this revision.Jan 10 2019, 11:53 PM
Jaehyun_Cho requested review of this revision.Jan 10 2019, 11:53 PM
segfaultxavi added inline comments.
src/bindings/mono/eo_mono/workaround.cs
137

Is this related to the patch? If yes, it should be explained.

Jaehyun_Cho edited the summary of this revision. (Show Details)Jan 13 2019, 8:41 PM

@segfaultxavi

Thank you for your comment :)
I updated commit message.

src/bindings/mono/eo_mono/workaround.cs
137

Thank you for comment here.

The following StateSet causes duplicate definition with this patch so it is removed.
I updated commit message to explain this removal.

felipealmeida accepted this revision.Jan 13 2019, 10:36 PM
This revision is now accepted and ready to land.Jan 13 2019, 10:36 PM
This revision was automatically updated to reflect the committed changes.

Ah, OK, thanks. I had not noticed that the removed lines where in workaround.cs. The ultimate goal is that workaround.cs disappears so... good work! :D