evas: make efl_canvas_group abstract
ClosedPublic
Actions

Authored by bu5hm4n on Fri, Jan 11, 5:35 AM.

Details

Reviewers

Hermet
zmike
segfaultxavi
cedric
Jaehyun_Cho

Maniphest Tasks

T7240: Not allow multi class inheritance in eo

Commits

rEFLae65c64b8d52: evas: make efl_canvas_group abstract

Summary

the efl_canvas_group should be abstract in order to support other
classes which are inheriting from it, which are abstract. This is done
in order to support only abstract parents from abstract classes.

ref T7240

Depends on D7599

Diff Detail

Repository

rEFL core/efl

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

bu5hm4n created this revision.Fri, Jan 11, 5:35 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Fri, Jan 11, 5:35 AM

bu5hm4n added a child revision: D7601: evas: make efl_canvas_animation abstract.

Harbormaster completed remote builds in B8768: Diff 18365.Fri, Jan 11, 5:36 AM

bu5hm4n added reviewers: Hermet, zmike, segfaultxavi, cedric, Jaehyun_Cho.Fri, Jan 11, 5:39 AM

Please explain in the commit why there is a need for the new Object you are introduced here and when people should use it instead of the abstract class. Just for documentation purpose.

This revision now requires changes to proceed.Fri, Jan 11, 10:53 AM

Yeah, I'd like to know what is going on here. The new Efl.Canvas.Group_Object regular class inherits from Efl.Canvas.Group (which is now abstract), but nobody uses it, except Efl.Ui.Pager that uses it to retrieve... something? Help?

bu5hm4n edited the summary of this revision. (Show Details)Mon, Jan 14, 9:46 AM

In D7600#134016, @segfaultxavi wrote:

Yeah, I'd like to know what is going on here. The new Efl.Canvas.Group_Object regular class inherits from Efl.Canvas.Group (which is now abstract), but nobody uses it, except Efl.Ui.Pager that uses it to retrieve... something? Help?

Efl.Ui.Pager uses it and the function evas_object_smart_add. Efl.Canvas.Group has to be abstract in order to support other abstract classes inheriting from it. However, since we have the case that we need it abstract and regular at the same time, I decided to have both, with the solution you see here.

bu5hm4n requested review of this revision.Mon, Jan 14, 9:49 AM

Ok, that makes sense, thanks!

However... you added a new class, which needs documenting :)

This revision now requires changes to proceed.Mon, Jan 14, 12:41 PM

we do love comments.

Harbormaster completed remote builds in B8804: Diff 18407.Mon, Jan 14, 1:22 PM

In D7600#134077, @bu5hm4n wrote:

we do love comments.

YES WE DO! 😁

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 15, 8:38 AM

Closed by commit rEFLae65c64b8d52: evas: make efl_canvas_group abstract (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/Makefile_Evas.am (1 line)
M		src/lib/elementary/efl_ui_pager.c (2 lines)
M		src/lib/evas/Evas_Eo.h (1 line)
M		src/lib/evas/canvas/efl_canvas_group.eo (2 lines)
A	M	src/lib/evas/canvas/efl_canvas_group_object.eo (7 lines)
M		src/lib/evas/canvas/evas_object_smart.c (3 lines)
M		src/lib/evas/canvas/meson.build (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18365	daf13a7		Fri, Jan 11, 5:35 AM	★	★
Diff 2	18407	149edf0	we do love comments.	Mon, Jan 14, 1:22 PM	★	★
Diff 3	18430	afa5368	rEFLae65c64b8d52c3b3d032eb29474b750b7e5781cb	Tue, Jan 15, 8:37 AM	★	★

Status	Author	Revision
Closed	bu5hm4n	D7601 evas: make efl_canvas_animation abstract
Closed	bu5hm4n	D7600 evas: make efl_canvas_group abstract
Closed	bu5hm4n	D7599 ecore: make efl_loop_consumer abstract