Details
- Reviewers
Hermet zmike segfaultxavi cedric Jaehyun_Cho - Maniphest Tasks
- T7240: Not allow multi class inheritance in eo
- Commits
- rEFLae65c64b8d52: evas: make efl_canvas_group abstract
Diff Detail
- Repository
- rEFL core/efl
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/
Please explain in the commit why there is a need for the new Object you are introduced here and when people should use it instead of the abstract class. Just for documentation purpose.
Yeah, I'd like to know what is going on here. The new Efl.Canvas.Group_Object regular class inherits from Efl.Canvas.Group (which is now abstract), but nobody uses it, except Efl.Ui.Pager that uses it to retrieve... something? Help?
Efl.Ui.Pager uses it and the function evas_object_smart_add. Efl.Canvas.Group has to be abstract in order to support other abstract classes inheriting from it. However, since we have the case that we need it abstract and regular at the same time, I decided to have both, with the solution you see here.
Ok, that makes sense, thanks!
However... you added a new class, which needs documenting :)