Page MenuHomePhabricator

evas: make efl_canvas_animation abstract
ClosedPublic

Authored by bu5hm4n on Fri, Jan 11, 5:35 AM.

Details

Summary

it seems that this class does not have a meaning when created just like
this. Other classes using it are even abstract, which means, this class
should also be abstract. This is done in order to support that a
abstract class should only contain abstract

ref T7240

Depends on D7600

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Fri, Jan 11, 5:35 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

bu5hm4n requested review of this revision.Fri, Jan 11, 5:35 AM
segfaultxavi accepted this revision.Fri, Jan 11, 8:22 AM

If it builds and examples can be executed (I haven't tested) means that this change is safe enough, right?

This revision is now accepted and ready to land.Fri, Jan 11, 8:22 AM
cedric accepted this revision.Fri, Jan 11, 10:35 AM

Make sense indeed.

bu5hm4n updated this revision to Diff 18408.Mon, Jan 14, 1:23 PM
bu5hm4n edited the summary of this revision. (Show Details)

rebase.

Closed by commit rEFLea9ff9f547b5: evas: make efl_canvas_animation abstract (authored by bu5hm4n, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyTue, Jan 15, 8:38 AM
This revision was automatically updated to reflect the committed changes.