Page MenuHomePhabricator
Differential D7603

tests: add test for elm_layout_text_set
ClosedPublic
Actions

Authored by zmike on Jan 11 2019, 9:27 AM.

Details

Reviewers
stefan_schmidt
cedric
Maniphest Tasks
T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text
Commits
rEFL0e027980f6c2: tests: add test for elm_layout_text_set
Summary

ref T6931

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zmike created this revision.Jan 11 2019, 9:27 AM
zmike requested review of this revision.Jan 11 2019, 9:27 AM
zmike added a parent revision: D7604: tests: use test namespace for elm_layout unit test function names.Jan 11 2019, 9:28 AM

This fails 100% of the time currently but should be merged when efl_ui_text is functional

zmike updated this revision to Diff 19223.Feb 6 2019, 12:56 PM
zmike retitled this revision from tests: add (failing) test for elm_layout_text_set to tests: add test for elm_layout_text_set.Feb 6 2019, 12:57 PM
zmike added a parent revision: D7888: efl_ui_layout: check part existence in text_set.
zmike removed a parent revision: D7604: tests: use test namespace for elm_layout unit test function names.

This can be landed with D7888

cedric accepted this revision.Feb 11 2019, 2:43 PM

The test make sense and can be landed when the problem is fixed.

This revision is now accepted and ready to land.Feb 11 2019, 2:43 PM
Closed by commit rEFL0e027980f6c2: tests: add test for elm_layout_text_set (authored by zmike). · Explain WhyFeb 27 2019, 1:04 PM
This revision was automatically updated to reflect the committed changes.
Jaehyun_Cho added a subscriber: Jaehyun_Cho.Mar 13 2019, 3:24 AM

@zmike

Since we should revert D7888, this patch is also required to be reverted just for now.
After a proper patch is applied instead of D7888, then I think that we can submit this patch again.

Revision Contents
Changeset List

Diff 19776

View Options

src/tests/elementary/elm_test_layout.c

Loading...