Page MenuHomePhabricator

efl_ui : add dummy object for verificate factory class.
AbandonedPublic

Authored by SanghyeonLee on Jan 14 2019, 12:28 AM.

Details

Summary

Efl_Class is not an object so efl_isa() is not validate about Efl_Class.
we can add one dummy object for validate efl_isa(),
or we could remove the validation check and give responsability to user.

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8787
Build 7734: arc lint + arc unit
SanghyeonLee created this revision.Jan 14 2019, 12:28 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

SanghyeonLee requested review of this revision.Jan 14 2019, 12:28 AM

Instantiating a whole new object just to check if a class implements a certain interface looks a bit overkill... Do we have API to check that @q66 ?

cedric requested changes to this revision.Jan 14 2019, 10:02 AM

Instantiating a whole new object just to check if a class implements a certain interface looks a bit overkill... Do we have API to check that @q66 ?

I agree with @segfaultxavi here. If there is no function that provide this feature, we should just patch efl_class to behave accordingly.

This revision now requires changes to proceed.Jan 14 2019, 10:02 AM

Instantiating a whole new object just to check if a class implements a certain interface looks a bit overkill... Do we have API to check that @q66 ?

I agree with @segfaultxavi here. If there is no function that provide this feature, we should just patch efl_class to behave accordingly.

+1

I also agree that is best for us.
this patch is not intended to fix real problem but just shows how it could be the worst :p

SanghyeonLee abandoned this revision.Jan 23 2019, 2:30 AM

abandoned