Page MenuHomePhabricator

elm_map: Make more robust elm_map
ClosedPublic

Authored by michael.bouchaud on Jan 14 2019, 4:35 AM.

Details

Summary

Make more robust elm_map even if the user wipe is cache directory
or import an already filled tile cache.

@fix T7443

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

michael.bouchaud requested review of this revision.Jan 14 2019, 4:35 AM
  • Add comment about the case the tile already exists

Tested and it works fine.
Thank's

cedric requested changes to this revision.Feb 11 2019, 2:47 PM
cedric added inline comments.
src/lib/elementary/elm_map.c
823

This seems like this is duplicating the code that is just below. Could you refactor this is a bit?

This revision now requires changes to proceed.Feb 11 2019, 2:47 PM
  • Code refactoring
michael.bouchaud marked an inline comment as done.Fri, Feb 22, 1:28 AM
zmike requested changes to this revision.Mon, Feb 25, 4:18 AM
zmike added inline comments.
src/lib/elementary/elm_map.c
824

This leaks dir_path.

828–842

This leaks dir_path.

This revision now requires changes to proceed.Mon, Feb 25, 4:18 AM
  • Avoid to leak dir_path
michael.bouchaud marked 2 inline comments as done.Mon, Feb 25, 9:08 AM
zmike accepted this revision.Mon, Feb 25, 11:00 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mon, Feb 25, 11:01 AM
Closed by commit rEFL5f85e61f6a46: elm_map: Make more robust elm_map (authored by Michaël Bouchaud (yoz) <yoz@efl.so>, committed by zmike). · Explain Why
This revision was automatically updated to reflect the committed changes.