Page MenuHomePhabricator
Differential D7622

focus_manager: fix memory leaks
ClosedPublic
Actions

Authored by ManMower on Jan 14 2019, 5:06 PM.

Details

Reviewers
bu5hm4n
Commits
rEFL5f207d79e352: focus_manager: fix memory leaks
Summary

_set_a_without_b() makes a list clone internally, so cloning the list
first will leak a copy.
Depends on D7621

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ManMower created this revision.Jan 14 2019, 5:06 PM
Herald added a project: efl. · View Herald TranscriptJan 14 2019, 5:06 PM
Herald added subscribers: committers, reviewers, cedric. · View Herald Transcript

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ManMower requested review of this revision.Jan 14 2019, 5:06 PM
ManMower added a reviewer: bu5hm4n.Jan 14 2019, 5:08 PM

Adding bu5hm4n on review as he knows this code better than anyone... Slap me if I've missed something obvious here!

bu5hm4n accepted this revision.Jan 14 2019, 11:45 PM

Looks good to me :)

This revision is now accepted and ready to land.Jan 14 2019, 11:45 PM
Closed by commit rEFL5f207d79e352: focus_manager: fix memory leaks (authored by ManMower). · Explain WhyJan 15 2019, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18438

View Options

src/lib/elementary/efl_ui_focus_manager_sub.c

Loading...