ecore: simplify Efl.Model_Composite_Selection by relying on parent class.
AbandonedPublic
Actions

Authored by cedric on Jan 16 2019, 6:28 PM.

Details

Reviewers

SanghyeonLee
felipealmeida
segfaultxavi
zmike

Maniphest Tasks

T7382: [MVVM] Efl.Ui.View_List Homogenous Support

Summary

With the improvement on both Efl.Model_Composite and Efl.Model_Composite_Boolean
it is now possible to simplify Efl.Model_Composite_Selection and remove the
problematic Efl.Model_Composite_Selection_Children.

Depends on D7655

Diff Detail

Repository

rEFL core/efl

Branch

T7382-devs/cedric/homogeneous

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8955

cedric created this revision.Jan 16 2019, 6:28 PM

Herald added subscribers: committers, reviewers. · View Herald TranscriptJan 16 2019, 6:28 PM

cedric requested review of this revision.Jan 16 2019, 6:28 PM

cedric added a child revision: D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..

Harbormaster completed remote builds in B8872: Diff 18515.Jan 16 2019, 6:32 PM

Rebase.

Harbormaster completed remote builds in B8911: Diff 18576.Jan 17 2019, 4:42 PM

Rebase.

Harbormaster completed remote builds in B8955: Diff 18633.Jan 18 2019, 12:21 PM

I think this patch need to be abandoned as it already merged in D7654

This revision now requires changes to proceed.Jan 25 2019, 2:54 AM

Indeed.

Revision Contents
Changeset List

		Path
~		src/Makefile_Ecore.am (1 line)
~		src/lib/ecore/Ecore_Eo.h (1 line)
~		src/lib/ecore/efl_model_composite_selection.c (369 lines)
~		src/lib/ecore/efl_model_composite_selection.eo (1 line)
D	M	src/lib/ecore/efl_model_composite_selection_children.eo (9 lines)
~		src/lib/ecore/meson.build (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18515	5e16157		Jan 16 2019, 6:28 PM	★	★
Diff 2	18576	75e295b	Rebase.	Jan 17 2019, 4:42 PM	★	★
Diff 3	18633	3c17043	Rebase.	Jan 18 2019, 12:20 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
3cec408ef085	d0963222ddd6	3c17043c353b	Cedric BAIL	(Show More…)	Jan 3 2019, 2:52 PM

Status	Author	Revision
Closed	cedric	D7665 elementary: add test for Efl.Ui.Model_Average.
Closed	cedric	D7664 elementary: add a test for Efl.Ui.Model_Exact.
Closed	cedric	D7663 elementary: add a test for Efl.Ui.Model_Homogeneous.
Closed	cedric	D7662 elementary: enable efl_ui_suite tests for meson build.
Closed	cedric	D7661 elementary: add internal Efl_Ui_Model_Average.
Closed	cedric	D7660 elementary: add internal Efl_Ui_Model_Exact.
Closed	cedric	D7659 elementary: add internal Efl_Ui_Model_Homogeneous.
Closed	cedric	D7658 elementary: add internal Efl_Ui_Model_Size.
Abandoned	cedric	D7657 ecore: correct Efl.Model_Composite_Selection test to use the new property name.
Abandoned	cedric	D7656 ecore: simplify Efl.Model_Composite_Selection by relying on parent class.
Abandoned	cedric	D7655 ecore: simplify Efl.Model_Composite_Boolean by relying on parent class.
Closed	cedric	D7654 ecore: add an index property on Efl.Model_Composite and handle children_slice_get.
Closed	cedric	D7653 ecore: fix memory leak when shutding down the application.
Closed	cedric	D7652 eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it.
Closed	cedric	D7701 eina: refactor eina_value_*_new.
Closed	cedric	D7700 eina: refactor eina_value_*_init.
Closed	cedric	D7699 eina: refactor eina_value_*_get.
Closed	cedric	D7651 eina: add tests for the new Eina_Value convert functions.
Closed	segfaultxavi	D7650 eina: add Eina_Value helper that convert efficiently to a target native C type.
Closed	cedric	D7649 eina: add tests for Eina_Value utility function eina_value_*_get.