Page MenuHomePhabricator

efl_ui_widget: set a proper legacy name for widget_parent_set
ClosedPublic

Authored by woohyun on Jan 16 2019, 10:19 PM.

Details

Summary

Previously, legacy name of this property was "elm_widget_parent_set".
But, in efl_ui_widget.eo.legacy.h, it's current name is
"elm_widget_widget_parent_set" which is not matched well with
"elm_widget_parent_get" at all.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
woohyun created this revision.Jan 16 2019, 10:19 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

woohyun requested review of this revision.Jan 16 2019, 10:19 PM
woohyun edited the summary of this revision. (Show Details)Jan 16 2019, 10:26 PM
woohyun added reviewers: q66, zmike.

@q66

Do you have any plan to auto-remove a duplicated word between @legacy_prefix and @property name ?

For example, if legacy_prefix is "elm_widget" and property name is "widget_parent" -
then, can we auto-generate its legacy as "elm_widget_parent_set" (not "elm_widget_widget_parent_set") ?

If there is no plan for this, I think this patch is proper.

bu5hm4n accepted this revision.Jan 22 2019, 11:07 PM
This revision is now accepted and ready to land.Jan 22 2019, 11:07 PM
Closed by commit rEFL3b35bacc804f: efl_ui_widget: set a proper legacy name for widget_parent_set (authored by woohyun, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 22 2019, 11:12 PM
This revision was automatically updated to reflect the committed changes.

@q66 might still be worth checking why the doubled "widget" did not get filtered out in the generator.