Page MenuHomePhabricator

ecore_audio: remove pure virtual functions from classes
ClosedPublic

Authored by bu5hm4n on Jan 17 2019, 2:06 AM.

Details

Summary

A call to a undefined function results in a NOP we can get the same
behaviour with @empty. In Ecore.Audio this pure_virtual function makes
sense, so make the class abstract.

ref T7632

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jan 17 2019, 2:06 AM
bu5hm4n requested review of this revision.Jan 17 2019, 2:06 AM
bu5hm4n updated this revision to Diff 18533.Jan 17 2019, 2:19 AM

next try

segfaultxavi accepted this revision.Jan 17 2019, 4:04 AM
This revision is now accepted and ready to land.Jan 17 2019, 4:04 AM
Closed by commit rEFL48b43928bbbe: ecore_audio: remove pure virtual functions from classes (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by q66). · Explain WhyJan 17 2019, 8:18 AM
This revision was automatically updated to reflect the committed changes.