Page MenuHomePhabricator
Differential D7669

ecore_audio: remove pure virtual functions from classes
ClosedPublic
Actions

Authored by bu5hm4n on Jan 17 2019, 2:06 AM.

Details

Reviewers
cedric
segfaultxavi
zmike
q66
Maniphest Tasks
T7632: eolian should only allow pure_virtual on abstract classes
Commits
rEFL48b43928bbbe: ecore_audio: remove pure virtual functions from classes
Summary

A call to a undefined function results in a NOP we can get the same
behaviour with @empty. In Ecore.Audio this pure_virtual function makes
sense, so make the class abstract.

ref T7632

Diff Detail

Repository
rEFL core/efl
Branch
master
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8889
bu5hm4n created this revision.Jan 17 2019, 2:06 AM
bu5hm4n requested review of this revision.Jan 17 2019, 2:06 AM
bu5hm4n added a child revision: D7670: efl_net: make efl.net.server.fd abstract.
bu5hm4n updated this revision to Diff 18533.Jan 17 2019, 2:19 AM

next try

segfaultxavi accepted this revision.Jan 17 2019, 4:04 AM
This revision is now accepted and ready to land.Jan 17 2019, 4:04 AM
Closed by commit rEFL48b43928bbbe: ecore_audio: remove pure virtual functions from classes (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by q66). · Explain WhyJan 17 2019, 8:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 18533

View Options

src/lib/ecore_audio/ecore_audio.eo

Loading...
View Options

src/lib/ecore_audio/ecore_audio_in.eo

Loading...