Page MenuHomePhabricator

efl_net: make efl.net.server.fd abstract
ClosedPublic

Authored by bu5hm4n on Jan 17 2019, 2:06 AM.

Details

Summary

noone instanciantes it directly, further more it has pure_virtual
functions, which are making sense. So making this class abstract does
fix the issue of pure_virtual functions in class.

ref T7632

Depends on D7669

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jan 17 2019, 2:06 AM
bu5hm4n requested review of this revision.Jan 17 2019, 2:06 AM
bu5hm4n updated this revision to Diff 18534.Jan 17 2019, 2:19 AM
bu5hm4n edited the summary of this revision. (Show Details)

next_try

bu5hm4n abandoned this revision.Jan 17 2019, 3:45 AM

Do not do this for now. This needs more refactoring, server should get a loop_fd object.

bu5hm4n reclaimed this revision.Jan 17 2019, 4:41 AM

Seems to be fine.

segfaultxavi accepted this revision.Jan 17 2019, 7:26 AM

Builds and makes sense.

This revision is now accepted and ready to land.Jan 17 2019, 7:26 AM
Closed by commit rEFL0a95767a0c95: efl_net: make efl.net.server.fd abstract (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by q66). · Explain WhyJan 17 2019, 8:18 AM
This revision was automatically updated to reflect the committed changes.