Page MenuHomePhabricator

efl_ui_focus_object: Don't pass NULL to child_focus_set
ClosedPublic

Authored by devilhorns on Jan 17 2019, 4:57 AM.

Details

Summary

When starting elementary_test, efl_ui_focus_object_child_focus_set is
getting passed NULL on startup because elm_test window has no parent.
This makes it difficult to debug and fix T7030 issues. In order to fix
the issue, this patch checks for a valid parent before calling
efl_ui_focus_object_child_focus_set so that it no longer gets passed
NULL on elm_test startup and we can set breakpoints on eo.c:637
without getting interrupted at startup.

ref T7030

Diff Detail

Repository
rEFL core/efl
Branch
devs/devilhorns/T7030
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8898
devilhorns created this revision.Jan 17 2019, 4:57 AM
devilhorns requested review of this revision.Jan 17 2019, 4:57 AM
bu5hm4n accepted this revision.Jan 17 2019, 4:59 AM
This revision is now accepted and ready to land.Jan 17 2019, 4:59 AM
Closed by commit rEFLc98288c20eba: efl_ui_focus_object: Don't pass NULL to child_focus_set (authored by devilhorns, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 17 2019, 5:46 AM
This revision was automatically updated to reflect the committed changes.