Page MenuHomePhabricator

elm_code: Pass widget data to _elm_code_widget_fill_line
ClosedPublic

Authored by ManMower on Jan 18 2019, 8:46 AM.

Details

Summary

We already have this looked up in all callers, and the lookup is mind
smashingly heavy. Just use what we have.

ref T6209
Depends on D7693

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ManMower created this revision.Jan 18 2019, 8:46 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ManMower requested review of this revision.Jan 18 2019, 8:46 AM

Dear reviewers, please pay close attention to the final hunk - I think this should be fine, but my EOAPI knowledge is thin on the ground.

devilhorns accepted this revision.Jan 18 2019, 9:19 AM

This looks ok to me, but my EOAPI knowledge is under the ground lol ;) So I will mark this as accepted by me, but will wait for another reviewer to verify & land

This revision is now accepted and ready to land.Jan 18 2019, 9:19 AM
zmike accepted this revision.Jan 18 2019, 9:41 AM

I don't see what the question is?

Just wanting to know if it's safe to assume pd is passed

This revision was automatically updated to reflect the committed changes.