Page MenuHomePhabricator

elm: note down all composite sections for widgets
ClosedPublic

Authored by bu5hm4n on Jan 23 2019, 8:19 AM.

Details

Summary

A lot of new widgets are using the new Scrollmanager class, the instance of this class is then attached via composition to the widget. This is providing the implementation for Efl.Ui.Scrollbar & Efl.Ui.Scrollable_Interactive.

In the text widgets the same applies to the internal interactive text widgets.

The tags widget is using the text entry as composite, and thus provides efl.ui.text api.

The addition of those composite { } sections are removing the particular unimplemented APIs from the eolian errors.

ref T7652
Depends on D7737

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bu5hm4n created this revision.Jan 23 2019, 8:19 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

zmike requested changes to this revision.Jan 23 2019, 11:46 AM
zmike added a subscriber: zmike.

This commit log is misleading as the changes do not only affect scrollers.

This revision now requires changes to proceed.Jan 23 2019, 11:46 AM
bu5hm4n retitled this revision from elm: note down all composite sections for scrollers to elm: note down all composite sections for widgets.Jan 23 2019, 11:50 AM
bu5hm4n edited the summary of this revision. (Show Details)
zmike accepted this revision.Jan 23 2019, 11:51 AM
This revision is now accepted and ready to land.Jan 23 2019, 11:51 AM
Closed by commit rEFL7c5c93eac059: elm: note down all composite sections for widgets (authored by Marcel Hollerbach <mail@marcel-hollerbach.de>, committed by zmike). · Explain WhyJan 23 2019, 11:57 AM
This revision was automatically updated to reflect the committed changes.