Page MenuHomePhabricator

eo: remove function efl_noref that duplicate EFL_EVENT_NOREF.
ClosedPublic

Authored by cedric on Jan 23 2019, 4:35 PM.

Details

Summary

efl_noref is unused, but will still trigger the full eo call for nothing.
This was the most expensive NOOP. EFL_EVENT_NOREF does the same thing and
we can even filter generating that call as we know when someone is listening.
So removing the function.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 23 2019, 4:35 PM
cedric requested review of this revision.Jan 23 2019, 4:35 PM
segfaultxavi accepted this revision.Jan 24 2019, 3:36 AM

Looks sensible enough. The constructor and destructor documentation should be updated too.

This revision is now accepted and ready to land.Jan 24 2019, 3:36 AM
ManMower accepted this revision.Jan 24 2019, 11:15 AM

I like this a lot. :)

This revision was automatically updated to reflect the committed changes.