Page MenuHomePhabricator

eo: propagate knowledge of EFL_EVENT_NOREF callback registration to the event call generation.
ClosedPublic

Authored by cedric on Jan 23 2019, 4:35 PM.

Details

Summary

This reduce the amount of time efl_event_callback_call(EFL_EVENT_NOREF) is triggered by a factor of 10.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cedric created this revision.Jan 23 2019, 4:35 PM
cedric requested review of this revision.Jan 23 2019, 4:35 PM

Not hugely familiar with this code, have asked one question.

factor of 10 seems grossly understated, more like a factor of hundreds or thousands in my limited testing. This seems like a decent win. :)

src/lib/eo/eo_base_class.c
1193

Is this correct? I would've thought the new code would go under the CB_COUNT_DEC() for noref...

cedric added inline comments.Jan 24 2019, 11:39 AM
src/lib/eo/eo_base_class.c
1193

Oh, good catch.

cedric updated this revision to Diff 18806.Jan 24 2019, 11:55 AM
cedric edited the summary of this revision. (Show Details)

Rebase and put the check in the right place.

ManMower requested changes to this revision.Jan 24 2019, 11:57 AM
ManMower added inline comments.
src/lib/eo/eo_base_class.c
1198

shouldn't this be event_cb_efl_event_noref_count?

This revision now requires changes to proceed.Jan 24 2019, 11:57 AM
cedric updated this revision to Diff 18808.Jan 24 2019, 12:17 PM

Fix naming.

ManMower accepted this revision.Jan 24 2019, 12:18 PM
This revision is now accepted and ready to land.Jan 24 2019, 12:18 PM
This revision was automatically updated to reflect the committed changes.