Page MenuHomePhabricator

elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly.

Authored by stephenmhouston on Jan 23 2019, 8:02 PM.



This adds a test that sets a custom progressbar format string that includes a custom percent (%%) that should be escaped to just one percent (%). This case has been broken and fixed many times and is broken again so it makes sense to now add a check for it to try and prevent the continual breakage.

Test Plan

elementary_test progressbar shows the bad format string. You will see 50%%. With this patch applied, ninja test will fail currently.

Diff Detail

rEFL core/efl
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
stephenmhouston requested review of this revision.Jan 23 2019, 8:02 PM

FYI the ticket showing that format is currently broken is:

cedric accepted this revision.Jan 24 2019, 8:11 AM

Perfect test. Let's land it when we have elementary fixed. Thank you.

This revision is now accepted and ready to land.Jan 24 2019, 8:11 AM

I added do not merge so it is out of the queue, we can land it once this is fixed.

This revision was automatically updated to reflect the committed changes.