Page MenuHomePhabricator

efl_task: remove* interfaces

Authored by woohyun on Jan 24 2019, 1:00 AM.



Remove* interfaces from efl_task, and make other extended
classes properly.

ref T7657
Depends on D7760

Test Plan

run tests

Diff Detail

rEFL core/efl
No Linters Available
No Unit Test Coverage
Build Status
Buildable 9063
Build 7822: arc lint + arc unit
woohyun created this revision.Jan 24 2019, 1:00 AM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added:

woohyun requested review of this revision.Jan 24 2019, 1:00 AM

Can you add "ref T7657" into the commit message ? This documents why this is done for the future :)


Our "loop" in efl isn't a real loop object, its a Efl.App. Thus we still have the interfaces here on our "loop" object. The interfaces should not be implemented here, and the code for the interfaces should be removed :)

bu5hm4n requested changes to this revision.Jan 24 2019, 1:24 AM
This revision now requires changes to proceed.Jan 24 2019, 1:24 AM
woohyun updated this revision to Diff 18836.Jan 25 2019, 12:57 AM
woohyun edited the summary of this revision. (Show Details)

Remove* implementing from efl_app

bu5hm4n accepted this revision.Jan 25 2019, 3:22 AM

This looks good to me, it removes the read / write API from the app object, which was considered not understable, and not so usefull to have it on the object itself.

This revision is now accepted and ready to land.Jan 25 2019, 3:22 AM
bu5hm4n updated this revision to Diff 18881.Jan 25 2019, 6:55 AM
bu5hm4n edited the summary of this revision. (Show Details)


cedric accepted this revision.Jan 25 2019, 11:22 AM

I think this is going to make things working with all language more likely. If someone needs this feature in C, it can still be done by manually connecting things.

ManMower accepted this revision.Jan 25 2019, 11:46 AM
ManMower added a subscriber: ManMower.

Nice! Looks like a sizeable reduction in complexity at the cost of a feature that seems dubious at best - and as cedric says, can be provided manually when it's actually necessary. I feel sometimes like EFL carries too much technical debt for features that very few devs actually need, so it's nice to see this go before eo stabilizes. ?

This revision was automatically updated to reflect the committed changes.