Page MenuHomePhabricator

gesture_manager: Filter events we add hooks for
ClosedPublic

Authored by ManMower on Jan 24 2019, 12:28 PM.

Details

Summary

Gesture manager doesn't care about focus manager events, animation events,
and various other things it's currently hooking.

We can save a lot of pointer indirection nonsense by only paying attention
to events it can actually do something with.

Depends on D7763

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ManMower created this revision.Jan 24 2019, 12:28 PM

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

ManMower requested review of this revision.Jan 24 2019, 12:28 PM
cedric requested changes to this revision.Jan 24 2019, 12:41 PM
cedric added inline comments.
src/lib/evas/gesture/efl_canvas_gesture_manager.c
358

Could you document where this list is coming from and document both side so that we keep them in sync somehow.

This revision now requires changes to proceed.Jan 24 2019, 12:41 PM
ManMower updated this revision to Diff 18885.Jan 25 2019, 8:46 AM
ManMower edited the summary of this revision. (Show Details)

Reorder the whitelist, add a couple of new events, and list where it's from

This revision was not accepted when it landed; it landed in state Needs Review.Jan 25 2019, 11:09 AM
This revision was automatically updated to reflect the committed changes.