Page MenuHomePhabricator

ecore-drm2: Support multiple gpus during vblank
ClosedPublic

Authored by devilhorns on Jan 28 2019, 8:34 AM.

Details

Summary

When we try to calculate a drm vblank type, we should take into
account the output's pipe value which is used to determine if we are
using multiple gpus (if so, we need to use the high_crtc_mask.

Diff Detail

Repository
rEFL core/efl
Branch
devs/devilhorns/multi-gpu
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9201
devilhorns created this revision.Jan 28 2019, 8:34 AM
devilhorns requested review of this revision.Jan 28 2019, 8:34 AM
ManMower requested changes to this revision.Jan 28 2019, 9:04 AM
ManMower added inline comments.
src/lib/ecore_drm2/ecore_drm2_outputs.c
1636

I think this line is incorrect - was it intended to be >= 1? Either way, this function is pretty naive, and we expect it to block if sequence is non zero, as we don't set up a proper event handler.

All else looks ok, but I think line 1636 should be left out?

This revision now requires changes to proceed.Jan 28 2019, 9:04 AM
devilhorns updated this revision to Diff 18968.Jan 28 2019, 9:16 AM

Removed erroneous line which was setting DRM_VBLANK_EVENT

devilhorns marked an inline comment as done.Jan 28 2019, 9:16 AM
ManMower accepted this revision.Jan 28 2019, 10:23 AM
This revision is now accepted and ready to land.Jan 28 2019, 10:23 AM
devilhorns closed this revision.Jan 28 2019, 11:45 AM