Page MenuHomePhabricator

meson: fix to make results same as a way it does in autotools
ClosedPublic

Authored by akanad on Jan 29 2019, 2:54 AM.

Details

Summary

I found that results of build are different by build tools.
this patch fixes meson.build to make results same as a way it does in autotools.

Diff Detail

Repository
rEFL core/efl
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
akanad created this revision.Jan 29 2019, 2:54 AM
akanad requested review of this revision.Jan 29 2019, 2:54 AM
cedric accepted this revision.Jan 29 2019, 1:40 PM
This revision is now accepted and ready to land.Jan 29 2019, 1:40 PM
bu5hm4n requested changes to this revision.Jan 30 2019, 12:18 AM

Don't get me wrong, but this revision does not even build, it does not even finish the configure stage, ... why is something like this submitted here, and further more, @cedric, why is it accepted ?

This revision now requires changes to proceed.Jan 30 2019, 12:18 AM
akanad updated this revision to Diff 19031.Jan 30 2019, 12:23 AM

that's my fault. :-O

bu5hm4n requested changes to this revision.Jan 30 2019, 12:26 AM

And this will break autotools build as configure.ac still requests EFLConfigVersion.cmake.in ...

This revision now requires changes to proceed.Jan 30 2019, 12:26 AM
akanad updated this revision to Diff 19032.Jan 30 2019, 12:43 AM

oops again, sorry!

bu5hm4n accepted this revision.Jan 30 2019, 3:22 AM
This revision is now accepted and ready to land.Jan 30 2019, 3:22 AM
Closed by commit rEFL31794a18e108: meson: fix to make results same as a way it does in autotools (authored by WhiskyKiloSq, committed by Marcel Hollerbach <mail@marcel-hollerbach.de>). · Explain WhyJan 30 2019, 4:33 AM
This revision was automatically updated to reflect the committed changes.